string_instrumentation.cpp

Go to the documentation of this file.

/*******************************************************************\
 
Module: String Abstraction
 
Author: Daniel Kroening, kroening@kroening.com
 
\*******************************************************************/
 
 
#include "string_instrumentation.h"
 
#include <algorithm>
 
#include <util/arith_tools.h>
#include <util/c_types.h>
#include <util/config.h>
#include <util/pointer_expr.h>
#include <util/std_code.h>
#include <util/string_constant.h>
 
#include <goto-programs/format_strings.h>
#include <goto-programs/goto_model.h>
#include <goto-programs/remove_skip.h>
 
exprt is_zero_string(const exprt &what, bool write)
{
  unary_exprt result{"is_zero_string", what, c_bool_type()};
  result.copy_to_operands(what);
  result.set("lhs", write);
  return notequal_exprt{result, from_integer(0, c_bool_type())};
}
 
exprt zero_string_length(
  const exprt &what,
  bool write)
{
  exprt result("zero_string_length", size_type());
  result.copy_to_operands(what);
  result.set("lhs", write);
  return result;
}
 
exprt buffer_size(const exprt &what)
{
  exprt result("buffer_size", size_type());
  result.copy_to_operands(what);
  return result;
}
 
class string_instrumentationt
{
public:
  explicit string_instrumentationt(symbol_table_baset &_symbol_table)
    : symbol_table(_symbol_table), ns(_symbol_table)
  {
  }
 
  void operator()(goto_programt &dest);
  void operator()(goto_functionst &dest);
 
protected:
  symbol_table_baset &symbol_table;
  namespacet ns;
 
  void instrument(goto_programt &dest, goto_programt::targett it);
  void do_function_call(goto_programt &dest, goto_programt::targett target);
 
  // strings
  void do_sprintf(
    goto_programt &dest,
    goto_programt::targett target,
    const exprt &lhs,
    const exprt::operandst &arguments);
  void do_snprintf(
    goto_programt &dest,
    goto_programt::targett target,
    const exprt &lhs,
    const exprt::operandst &arguments);
  void do_strcat(
    goto_programt &dest,
    goto_programt::targett it,
    const exprt &lhs,
    const exprt::operandst &arguments);
  void do_strncmp(
    goto_programt &dest,
    goto_programt::targett it,
    const exprt &lhs,
    const exprt::operandst &arguments);
  void do_strchr(
    goto_programt &dest,
    goto_programt::targett target,
    const exprt &lhs,
    const exprt::operandst &arguments);
  void do_strrchr(
    goto_programt &dest,
    goto_programt::targett target,
    const exprt &lhs,
    const exprt::operandst &arguments);
  void do_strstr(
    goto_programt &dest,
    goto_programt::targett target,
    const exprt &lhs,
    const exprt::operandst &arguments);
  void do_strtok(
    goto_programt &dest,
    goto_programt::targett target,
    const exprt &lhs,
    const exprt::operandst &arguments);
  void do_strerror(
    goto_programt &dest,
    goto_programt::targett it,
    const exprt &lhs,
    const exprt::operandst &arguments);
  void do_fscanf(
    goto_programt &dest,
    goto_programt::targett target,
    const exprt &lhs,
    const exprt::operandst &arguments);
 
  void do_format_string_read(
    goto_programt &dest,
    goto_programt::const_targett target,
    const code_function_callt::argumentst &arguments,
    std::size_t format_string_inx,
    std::size_t argument_start_inx,
    const std::string &function_name);
 
  void do_format_string_write(
    goto_programt &dest,
    goto_programt::const_targett target,
    const code_function_callt::argumentst &arguments,
    std::size_t format_string_inx,
    std::size_t argument_start_inx,
    const std::string &function_name);
 
  bool is_string_type(const typet &t) const
  {
    return (t.id() == ID_pointer || t.id() == ID_array) &&
           (to_type_with_subtype(t).subtype().id() == ID_signedbv ||
            to_type_with_subtype(t).subtype().id() == ID_unsignedbv) &&
           (to_bitvector_type(to_type_with_subtype(t).subtype()).get_width() ==
            config.ansi_c.char_width);
  }
 
  void invalidate_buffer(
    goto_programt &dest,
    goto_programt::const_targett target,
    const exprt &buffer,
    const typet &buf_type,
    const mp_integer &limit);
};
 
void string_instrumentation(
  symbol_table_baset &symbol_table,
  goto_programt &dest)
{
  string_instrumentationt string_instrumentation{symbol_table};
  string_instrumentation(dest);
}
 
void string_instrumentation(
  symbol_table_baset &symbol_table,
  goto_functionst &dest)
{
  string_instrumentationt string_instrumentation{symbol_table};
  string_instrumentation(dest);
}
 
void string_instrumentation(goto_modelt &goto_model)
{
  string_instrumentation(
    goto_model.symbol_table,
    goto_model.goto_functions);
}
 
void string_instrumentationt::operator()(goto_functionst &dest)
{
  for(goto_functionst::function_mapt::iterator
      it=dest.function_map.begin();
      it!=dest.function_map.end();
      it++)
  {
    (*this)(it->second.body);
  }
}
 
void string_instrumentationt::operator()(goto_programt &dest)
{
  Forall_goto_program_instructions(it, dest)
    instrument(dest, it);
}
 
void string_instrumentationt::instrument(
  goto_programt &dest,
  goto_programt::targett it)
{
  if(it->is_function_call())
    do_function_call(dest, it);
}
 
void string_instrumentationt::do_function_call(
  goto_programt &dest,
  goto_programt::targett target)
{
  const exprt &lhs = as_const(*target).call_lhs();
  const exprt &function = as_const(*target).call_function();
  const auto &arguments = as_const(*target).call_arguments();
 
  if(function.id()==ID_symbol)
  {
    const irep_idt &identifier=
      to_symbol_expr(function).get_identifier();
 
    if(identifier=="strcoll")
    {
    }
    else if(identifier=="strncmp")
      do_strncmp(dest, target, lhs, arguments);
    else if(identifier=="strxfrm")
    {
    }
    else if(identifier=="strchr")
      do_strchr(dest, target, lhs, arguments);
    else if(identifier=="strcspn")
    {
    }
    else if(identifier=="strpbrk")
    {
    }
    else if(identifier=="strrchr")
      do_strrchr(dest, target, lhs, arguments);
    else if(identifier=="strspn")
    {
    }
    else if(identifier=="strerror")
      do_strerror(dest, target, lhs, arguments);
    else if(identifier=="strstr")
      do_strstr(dest, target, lhs, arguments);
    else if(identifier=="strtok")
      do_strtok(dest, target, lhs, arguments);
    else if(identifier=="sprintf")
      do_sprintf(dest, target, lhs, arguments);
    else if(identifier=="snprintf")
      do_snprintf(dest, target, lhs, arguments);
    else if(identifier == "fscanf" || identifier == "__isoc99_fscanf")
      do_fscanf(dest, target, lhs, arguments);
 
    remove_skip(dest);
  }
}
 
void string_instrumentationt::do_sprintf(
  goto_programt &dest,
  goto_programt::targett target,
  const exprt &lhs,
  const exprt::operandst &arguments)
{
  if(arguments.size()<2)
  {
    throw invalid_source_file_exceptiont(
      "sprintf expected to have two or more arguments",
      target->source_location());
  }
 
  goto_programt tmp;
 
  // in the abstract model, we have to report a
  // (possibly false) positive here
  source_locationt annotated_location = target->source_location();
  annotated_location.set_property_class("string");
  annotated_location.set_comment("sprintf buffer overflow");
  tmp.add(goto_programt::make_assertion(false_exprt(), annotated_location));
 
  do_format_string_read(tmp, target, arguments, 1, 2, "sprintf");
 
  if(lhs.is_not_nil())
  {
    exprt rhs = side_effect_expr_nondett(lhs.type(), target->source_location());
 
    tmp.add(
      goto_programt::make_assignment(lhs, rhs, target->source_location()));
  }
 
  target->turn_into_skip();
  dest.insert_before_swap(target, tmp);
}
 
void string_instrumentationt::do_snprintf(
  goto_programt &dest,
  goto_programt::targett target,
  const exprt &lhs,
  const exprt::operandst &arguments)
{
  if(arguments.size()<3)
  {
    throw invalid_source_file_exceptiont(
      "snprintf expected to have three or more arguments",
      target->source_location());
  }
 
  goto_programt tmp;
 
  exprt bufsize = buffer_size(arguments[0]);
 
  source_locationt annotated_location = target->source_location();
  annotated_location.set_property_class("string");
  annotated_location.set_comment("snprintf buffer overflow");
  tmp.add(goto_programt::make_assertion(
    binary_relation_exprt(bufsize, ID_ge, arguments[1]), annotated_location));
 
  do_format_string_read(tmp, target, arguments, 2, 3, "snprintf");
 
  if(lhs.is_not_nil())
  {
    exprt rhs = side_effect_expr_nondett(lhs.type(), target->source_location());
 
    tmp.add(
      goto_programt::make_assignment(lhs, rhs, target->source_location()));
  }
 
  target->turn_into_skip();
  dest.insert_before_swap(target, tmp);
}
 
void string_instrumentationt::do_fscanf(
  goto_programt &dest,
  goto_programt::targett target,
  const exprt &lhs,
  const exprt::operandst &arguments)
{
  if(arguments.size()<2)
  {
    throw invalid_source_file_exceptiont(
      "fscanf expected to have two or more arguments",
      target->source_location());
  }
 
  goto_programt tmp;
 
  do_format_string_write(tmp, target, arguments, 1, 2, "fscanf");
 
  if(lhs.is_not_nil())
  {
    exprt rhs = side_effect_expr_nondett(lhs.type(), target->source_location());
 
    tmp.add(
      goto_programt::make_assignment(lhs, rhs, target->source_location()));
  }
 
  target->turn_into_skip();
  dest.insert_before_swap(target, tmp);
}
 
void string_instrumentationt::do_format_string_read(
  goto_programt &dest,
  goto_programt::const_targett target,
  const code_function_callt::argumentst &arguments,
  std::size_t format_string_inx,
  std::size_t argument_start_inx,
  const std::string &function_name)
{
  const exprt &format_arg=arguments[format_string_inx];
 
  if(
    format_arg.id() == ID_address_of &&
    to_address_of_expr(format_arg).object().id() == ID_index &&
    to_index_expr(to_address_of_expr(format_arg).object()).array().id() ==
      ID_string_constant)
  {
    format_token_listt token_list = parse_format_string(id2string(
      to_string_constant(
        to_index_expr(to_address_of_expr(format_arg).object()).array())
        .value()));
 
    std::size_t args=0;
 
    for(const auto &token : token_list)
    {
      if(token.type==format_tokent::token_typet::STRING)
      {
        const exprt &arg=arguments[argument_start_inx+args];
 
        if(arg.id()!=ID_string_constant) // we don't need to check constants
        {
          exprt temp(arg);
 
          if(arg.type().id() != ID_pointer)
          {
            index_exprt index(temp, from_integer(0, c_index_type()));
            temp=address_of_exprt(index);
          }
 
          source_locationt annotated_location = target->source_location();
          annotated_location.set_property_class("string");
          std::string comment("zero-termination of string argument of ");
          comment += function_name;
          annotated_location.set_comment(comment);
          dest.add(goto_programt::make_assertion(
            is_zero_string(temp), annotated_location));
        }
      }
 
      if(token.type!=format_tokent::token_typet::TEXT &&
         token.type!=format_tokent::token_typet::UNKNOWN) args++;
 
      if(find(
           token.flags.begin(),
           token.flags.end(),
           format_tokent::flag_typet::ASTERISK)!=
         token.flags.end())
        args++; // just eat the additional argument
    }
  }
  else // non-const format string
  {
    source_locationt annotated_location = target->source_location();
    annotated_location.set_property_class("string");
    annotated_location.set_comment(
      "zero-termination of format string of " + function_name);
    dest.add(goto_programt::make_assertion(
      is_zero_string(arguments[1]), annotated_location));
 
    for(std::size_t i=2; i<arguments.size(); i++)
    {
      const exprt &arg=arguments[i];
 
      if(arguments[i].id() != ID_string_constant && is_string_type(arg.type()))
      {
        exprt temp(arg);
 
        if(arg.type().id() != ID_pointer)
        {
          index_exprt index(temp, from_integer(0, c_index_type()));
          temp=address_of_exprt(index);
        }
 
        source_locationt annotated_location = target->source_location();
        annotated_location.set_property_class("string");
        annotated_location.set_comment(
          "zero-termination of string argument of " + function_name);
        dest.add(goto_programt::make_assertion(
          is_zero_string(temp), annotated_location));
      }
    }
  }
}
 
void string_instrumentationt::do_format_string_write(
  goto_programt &dest,
  goto_programt::const_targett target,
  const code_function_callt::argumentst &arguments,
  std::size_t format_string_inx,
  std::size_t argument_start_inx,
  const std::string &function_name)
{
  const exprt &format_arg=arguments[format_string_inx];
 
  if(
    format_arg.id() == ID_address_of &&
    to_address_of_expr(format_arg).object().id() == ID_index &&
    to_index_expr(to_address_of_expr(format_arg).object()).array().id() ==
      ID_string_constant) // constant format
  {
    format_token_listt token_list = parse_format_string(id2string(
      to_string_constant(
        to_index_expr(to_address_of_expr(format_arg).object()).array())
        .value()));
 
    std::size_t args=0;
 
    for(const auto &token : token_list)
    {
      if(find(
           token.flags.begin(),
           token.flags.end(),
           format_tokent::flag_typet::ASTERISK)!=
         token.flags.end())
        continue; // asterisk means `ignore this'
 
      switch(token.type)
      {
        case format_tokent::token_typet::STRING:
        {
          const exprt &argument=arguments[argument_start_inx+args];
          const typet &arg_type = argument.type();
 
          exprt condition;
 
          if(token.field_width!=0)
          {
            exprt fwidth=from_integer(token.field_width, unsigned_int_type());
            exprt one=from_integer(1, unsigned_int_type());
            const plus_exprt fw_1(fwidth, one); // +1 for 0-char
 
            exprt fw_lt_bs;
 
            if(arg_type.id()==ID_pointer)
              fw_lt_bs=
                binary_relation_exprt(fw_1, ID_le, buffer_size(argument));
            else
            {
              const index_exprt index(
                argument, from_integer(0, unsigned_int_type()));
              address_of_exprt aof(index);
              fw_lt_bs=binary_relation_exprt(fw_1, ID_le, buffer_size(aof));
            }
 
            condition = fw_lt_bs;
          }
          else
          {
            // this is a possible overflow.
            condition = false_exprt();
          }
 
          source_locationt annotated_location = target->source_location();
          annotated_location.set_property_class("string");
          std::string comment("format string buffer overflow in ");
          comment += function_name;
          annotated_location.set_comment(comment);
          dest.add(
            goto_programt::make_assertion(condition, annotated_location));
 
          // now kill the contents
          invalidate_buffer(
            dest, target, argument, arg_type, token.field_width);
 
          args++;
          break;
        }
        case format_tokent::token_typet::TEXT:
        case format_tokent::token_typet::UNKNOWN:
        {
          // nothing
          break;
        }
        case format_tokent::token_typet::POINTER:
        case format_tokent::token_typet::CHAR:
        case format_tokent::token_typet::FLOAT:
        case format_tokent::token_typet::INT:
        {
          const exprt &argument=arguments[argument_start_inx+args];
          const dereference_exprt lhs{argument};
 
          side_effect_expr_nondett rhs(lhs.type(), target->source_location());
 
          dest.add(goto_programt::make_assignment(
            lhs, rhs, target->source_location()));
 
          args++;
          break;
        }
      }
    }
  }
  else // non-const format string
  {
    for(std::size_t i=argument_start_inx; i<arguments.size(); i++)
    {
      const typet &arg_type = arguments[i].type();
 
      // Note: is_string_type() is a `good guess' here. Actually
      // any of the pointers could point into an array. But it
      // would suck if we had to invalidate all variables.
      // Luckily this case isn't needed too often.
      if(is_string_type(arg_type))
      {
        // as we don't know any field width for the %s that
        // should be here during runtime, we just report a
        // possibly false positive
        source_locationt annotated_location = target->source_location();
        annotated_location.set_property_class("string");
        std::string comment("format string buffer overflow in ");
        comment += function_name;
        annotated_location.set_comment(comment);
        dest.add(
          goto_programt::make_assertion(false_exprt(), annotated_location));
 
        invalidate_buffer(dest, target, arguments[i], arg_type, 0);
      }
      else
      {
        dereference_exprt lhs{arguments[i]};
 
        side_effect_expr_nondett rhs(lhs.type(), target->source_location());
 
        dest.add(
          goto_programt::make_assignment(lhs, rhs, target->source_location()));
      }
    }
  }
}
 
void string_instrumentationt::do_strncmp(
  goto_programt &,
  goto_programt::targett,
  const exprt &,
  const exprt::operandst &)
{
}
 
void string_instrumentationt::do_strchr(
  goto_programt &dest,
  goto_programt::targett target,
  const exprt &lhs,
  const exprt::operandst &arguments)
{
  if(arguments.size()!=2)
  {
    throw invalid_source_file_exceptiont(
      "strchr expected to have two arguments", target->source_location());
  }
 
  source_locationt annotated_location = target->source_location();
  annotated_location.set_property_class("string");
  annotated_location.set_comment(
    "zero-termination of string argument of strchr");
  goto_programt::instructiont assertion = goto_programt::make_assertion(
    is_zero_string(arguments[0]), annotated_location);
 
  target->turn_into_skip();
  dest.insert_before_swap(target, assertion);
}
 
void string_instrumentationt::do_strrchr(
  goto_programt &dest,
  goto_programt::targett target,
  const exprt &lhs,
  const exprt::operandst &arguments)
{
  if(arguments.size()!=2)
  {
    throw invalid_source_file_exceptiont(
      "strrchr expected to have two arguments", target->source_location());
  }
 
  source_locationt annotated_location = target->source_location();
  annotated_location.set_property_class("string");
  annotated_location.set_comment(
    "zero-termination of string argument of strrchr");
  goto_programt::instructiont assertion = goto_programt::make_assertion(
    is_zero_string(arguments[0]), annotated_location);
 
  target->turn_into_skip();
  dest.insert_before_swap(target, assertion);
}
 
void string_instrumentationt::do_strstr(
  goto_programt &dest,
  goto_programt::targett target,
  const exprt &lhs,
  const exprt::operandst &arguments)
{
  if(arguments.size()!=2)
  {
    throw invalid_source_file_exceptiont(
      "strstr expected to have two arguments", target->source_location());
  }
 
  goto_programt tmp;
 
  source_locationt annotated_location = target->source_location();
  annotated_location.set_property_class("string");
  annotated_location.set_comment(
    "zero-termination of 1st string argument of strstr");
  tmp.add(goto_programt::make_assertion(
    is_zero_string(arguments[0]), annotated_location));
 
  annotated_location.set_property_class("string");
  annotated_location.set_comment(
    "zero-termination of 2nd string argument of strstr");
  tmp.add(goto_programt::make_assertion(
    is_zero_string(arguments[1]), annotated_location));
 
  target->turn_into_skip();
  dest.insert_before_swap(target, tmp);
}
 
void string_instrumentationt::do_strtok(
  goto_programt &dest,
  goto_programt::targett target,
  const exprt &lhs,
  const exprt::operandst &arguments)
{
  if(arguments.size()!=2)
  {
    throw invalid_source_file_exceptiont(
      "strtok expected to have two arguments", target->source_location());
  }
 
  goto_programt tmp;
 
  source_locationt annotated_location = target->source_location();
  annotated_location.set_property_class("string");
  annotated_location.set_comment(
    "zero-termination of 1st string argument of strtok");
  tmp.add(goto_programt::make_assertion(
    is_zero_string(arguments[0]), annotated_location));
 
  annotated_location.set_property_class("string");
  annotated_location.set_comment(
    "zero-termination of 2nd string argument of strtok");
  tmp.add(goto_programt::make_assertion(
    is_zero_string(arguments[1]), annotated_location));
 
  target->turn_into_skip();
  dest.insert_before_swap(target, tmp);
}
 
void string_instrumentationt::do_strerror(
  goto_programt &dest,
  goto_programt::targett it,
  const exprt &lhs,
  const exprt::operandst &arguments)
{
  if(lhs.is_nil())
  {
    it->turn_into_skip();
    return;
  }
 
  irep_idt identifier_buf="__strerror_buffer";
  irep_idt identifier_size="__strerror_buffer_size";
 
  if(symbol_table.symbols.find(identifier_buf)==symbol_table.symbols.end())
  {
    symbolt new_symbol_size{identifier_size, size_type(), ID_C};
    new_symbol_size.base_name = identifier_size;
    new_symbol_size.pretty_name=new_symbol_size.base_name;
    new_symbol_size.is_state_var=true;
    new_symbol_size.is_lvalue=true;
    new_symbol_size.is_static_lifetime=true;
 
    array_typet type(char_type(), new_symbol_size.symbol_expr());
    symbolt new_symbol_buf{identifier_buf, type, ID_C};
    new_symbol_buf.is_state_var=true;
    new_symbol_buf.is_lvalue=true;
    new_symbol_buf.is_static_lifetime=true;
    new_symbol_buf.base_name = identifier_buf;
    new_symbol_buf.pretty_name=new_symbol_buf.base_name;
 
    symbol_table.insert(std::move(new_symbol_buf));
    symbol_table.insert(std::move(new_symbol_size));
  }
 
  const symbolt &symbol_size=ns.lookup(identifier_size);
  const symbolt &symbol_buf=ns.lookup(identifier_buf);
 
  goto_programt tmp;
 
  {
    exprt nondet_size =
      side_effect_expr_nondett(size_type(), it->source_location());
    tmp.add(goto_programt::make_assignment(
      code_assignt(symbol_size.symbol_expr(), nondet_size),
      it->source_location()));
 
    tmp.add(goto_programt::make_assumption(
      binary_relation_exprt(
        symbol_size.symbol_expr(),
        ID_notequal,
        from_integer(0, symbol_size.type)),
      it->source_location()));
  }
 
  // return a pointer to some magic buffer
  index_exprt index(
    symbol_buf.symbol_expr(), from_integer(0, c_index_type()), char_type());
 
  address_of_exprt ptr(index);
 
  // make that zero-terminated
  tmp.add(goto_programt::make_assignment(
    unary_exprt{"is_zero_string", ptr, c_bool_type()},
    from_integer(1, c_bool_type()),
    it->source_location()));
 
  // assign address
  {
    exprt rhs = typecast_exprt::conditional_cast(ptr, lhs.type());
    tmp.add(goto_programt::make_assignment(
      code_assignt(lhs, rhs), it->source_location()));
  }
 
  it->turn_into_skip();
  dest.insert_before_swap(it, tmp);
}
 
void string_instrumentationt::invalidate_buffer(
  goto_programt &dest,
  goto_programt::const_targett target,
  const exprt &buffer,
  const typet &buf_type,
  const mp_integer &limit)
{
  irep_idt cntr_id="string_instrumentation::$counter";
 
  if(symbol_table.symbols.find(cntr_id)==symbol_table.symbols.end())
  {
    symbolt new_symbol{cntr_id, size_type(), ID_C};
    new_symbol.base_name="$counter";
    new_symbol.pretty_name=new_symbol.base_name;
    new_symbol.is_state_var=true;
    new_symbol.is_lvalue=true;
    new_symbol.is_static_lifetime=true;
 
    symbol_table.insert(std::move(new_symbol));
  }
 
  const symbolt &cntr_sym=ns.lookup(cntr_id);
 
  // create a loop that runs over the buffer
  // and invalidates every element
 
  dest.add(goto_programt::make_assignment(
    cntr_sym.symbol_expr(),
    from_integer(0, cntr_sym.type),
    target->source_location()));
 
  exprt bufp;
 
  if(buf_type.id()==ID_pointer)
    bufp=buffer;
  else
  {
    index_exprt index(
      buffer,
      from_integer(0, c_index_type()),
      to_type_with_subtype(buf_type).subtype());
    bufp=address_of_exprt(index);
  }
 
  exprt condition;
 
  if(limit==0)
    condition =
      binary_relation_exprt(cntr_sym.symbol_expr(), ID_ge, buffer_size(bufp));
  else
    condition = binary_relation_exprt(
      cntr_sym.symbol_expr(), ID_gt, from_integer(limit, unsigned_int_type()));
 
  goto_programt::targett check = dest.add(
    goto_programt::make_incomplete_goto(condition, target->source_location()));
 
  const plus_exprt b_plus_i(bufp, cntr_sym.symbol_expr());
  const dereference_exprt deref(
    b_plus_i, to_type_with_subtype(buf_type).subtype());
 
  const side_effect_expr_nondett nondet(
    to_type_with_subtype(buf_type).subtype(), target->source_location());
 
  // invalidate
  dest.add(
    goto_programt::make_assignment(deref, nondet, target->source_location()));
 
  const plus_exprt plus(
    cntr_sym.symbol_expr(), from_integer(1, unsigned_int_type()));
 
  dest.add(goto_programt::make_assignment(
    cntr_sym.symbol_expr(), plus, target->source_location()));
 
  dest.add(
    goto_programt::make_goto(check, true_exprt(), target->source_location()));
 
  goto_programt::targett exit =
    dest.add(goto_programt::make_skip(target->source_location()));
 
  check->complete_goto(exit);
}